Possible issue: number of databytes for midi messages

banneduser · August 15, 2008

Hi together,

very interesting and productive community here.

I have just skimmed over the source code of your midi operation

system and noticed a possible issue:

file: mios_isr.inc

function: IRQ_UART_Rx_Hlp_GetCMax

This function is used to evaluate the number of databytes

expected for a particular message type.

For message 0xF3 (song select) the function seems to return

0 expected databytes, whereas, according to the midi specification,

the message should have 1 databyte.

So long,

carry on with your nice project!

latchup

TK. · August 15, 2008

Hi,

thank you! This was probably the oldest bug ever. It seems that not that much MIDI devices are using the song select message...

The bugfix is available in the repository:

Best Regards, Thorsten.

stryd_one · August 16, 2008

hahahah wow, how did that go unnoticed for so long ;D

Welcome abourd latchup! That's a fine way to enter the community, fixing a bug! :D

Recommended Posts