latchup Posted August 15, 2008 Report Share Posted August 15, 2008 Hi together,very interesting and productive community here.I have just skimmed over the source code of your midi operationsystem and noticed a possible issue:file: mios_isr.incfunction: IRQ_UART_Rx_Hlp_GetCMaxThis function is used to evaluate the number of databytesexpected for a particular message type.For message 0xF3 (song select) the function seems to return0 expected databytes, whereas, according to the midi specification,the message should have 1 databyte.So long,carry on with your nice project!latchup Quote Link to comment Share on other sites More sharing options...
TK. Posted August 15, 2008 Report Share Posted August 15, 2008 Hi,thank you! This was probably the oldest bug ever. It seems that not that much MIDI devices are using the song select message...The bugfix is available in the repository:http://svnmios.midibox.org/filedetails.php?repname=svn.mios&path=%2Ftrunk%2Fmios%2Fmios_isr.incBest Regards, Thorsten. Quote Link to comment Share on other sites More sharing options...
stryd_one Posted August 16, 2008 Report Share Posted August 16, 2008 hahahah wow, how did that go unnoticed for so long ;DWelcome abourd latchup! That's a fine way to enter the community, fixing a bug! :D Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.