restoring seq_ui_button_state.FAST_ENCODERS from BM flag does not work

[k2z3k0]

when restoring seq_ui_button_state.FAST_ENCODERS from recalled BM lights the led ,but FAST does not work,

i tried also to seq_ui_button_state.FAST_ENCODERS = 1; when switching to MIXER page, and FAST led comes up but no effect

 

can some one confirm?

any ideas?

 

best regards

Edited April 5 by k2z3k0
dyslexia

[TK.]

How could I reproduce this issue? Could you please give step-by-step instructions?

Best Regards, Thorsten.

[k2z3k0]

On 4/12/2024 at 9:11 PM, TK. said:

How could I reproduce this issue? Could you please give step-by-step instructions?

Best Regards, Thorsten.

hello T

 

ok so i am on http://www.ucapps.de/mios32/midibox_seq_v4_098_pre2.zip

fresh new project

1.make GLOBAL BOOKMARK #1 for DIVIDER with FAST ON,

2.FAST is ON and CLOCK GP #2 scrolls fast,

3.switch to EDIT page ,FAST is automatically turned off,

4.recall GLOBAL BOOKMARK #1 ,FAST is ON BUT not working,CLOCK GP #2 scrolls normal 

5.switch to EDIT page,turn on FAST,recall BOOKMARK #1 now FAST is ON and working

in SEQ_UI.C  it says

Quote

 

s32 SEQ_UI_Bookmark_Store(u8 bookmark)

{

  if( bookmark >= SEQ_UI_BOOKMARKS_NUM )

    return -1;

 

  seq_ui_bookmark_t *bm = (seq_ui_bookmark_t *)&seq_ui_bookmarks[bookmark];

 

  // note: name, enable flags and flags.LOCKED not overwritten!

 

  //bm->flags.SOLO = seq_ui_button_state.SOLO;

  bm->flags.CHANGE_ALL_STEPS = seq_ui_button_state.CHANGE_ALL_STEPS;

  bm->flags.FAST = seq_ui_button_state.FAST_ENCODERS;

 

and to restore 

Quote

 

s32 SEQ_UI_Bookmark_Restore(u8 bookmark)

{

  if( bookmark >= SEQ_UI_BOOKMARKS_NUM )

    return -1;

 

  seq_ui_bookmark_t *bm = (seq_ui_bookmark_t *)&seq_ui_bookmarks[bookmark];

 

  // should be atomic

  portENTER_CRITICAL();

  //if( bm->enable.SOLO )              seq_ui_button_state.SOLO = bm->flags.SOLO;

  if( bm->enable.CHANGE_ALL_STEPS )  seq_ui_button_state.CHANGE_ALL_STEPS = bm->flags.CHANGE_ALL_STEPS;

  if( bm->enable.FAST )              seq_ui_button_state.FAST_ENCODERS = bm->flags.FAST;

 

 

i think there might be a bug somewhere,something missing

it seems seq_ui_button_state.FAST_ENCODERS = 1 is turning FAST button LED on but not the FAST function when recalled from BOOKMARKS

 

i also tried to use seq_ui_button_state.FAST_ENCODERS = 1 for example when switching to MIXER page so my encoders work fast in MIXER page,but same effect

 

 

p.s.

while i have your attention ,

in HUMANIZER there is 2nd option VEL/CC ,should that humanize VELOCITY and MIDI CC messages from PARAMETER LAYERS of the track?

cause when i set track with one CC param HUMANIZER does not humanize that CC layer

 

thank you for your time

best regards

Kazik

Edited April 14 by k2z3k0